Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pager Indicators] Fix: #768 #783

Merged
merged 5 commits into from
Oct 13, 2021
Merged

[Pager Indicators] Fix: #768 #783

merged 5 commits into from
Oct 13, 2021

Conversation

ch4rl3x
Copy link
Contributor

@ch4rl3x ch4rl3x commented Oct 12, 2021

Closes #768

The currentPage has to be changed, when the item count in the pager changes and the currentPage has ahigher index than the new count allows.

I added a button to the HorizontalPagerTabsSample to change the toggle the item count in the pager

Copy link
Collaborator

@andkulikov andkulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing it!
Don't you mind writing a simple test for such case in PagerTest?

Copy link
Collaborator

@andkulikov andkulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andkulikov andkulikov merged commit 355521b into google:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rememberPagerState doesn't allow a reset on pageCount changed
2 participants